Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent errors in existing cases binding props with v-model #11045

Closed
wants to merge 4 commits into from
Closed

Prevent errors in existing cases binding props with v-model #11045

wants to merge 4 commits into from

Conversation

cnotv
Copy link
Contributor

@cnotv cnotv commented May 16, 2024 •
edited

Summary

Fixes #11029

Occurred changes and/or fixed issues

Technical notes summary

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@rancher-ui-project-bot rancher-ui-project-bot bot added this to the v2.9.0 milestone May 16, 2024
@nwmac nwmac modified the milestones: v2.9.0, v2.10.0 Jul 1, 2024
@cnotv cnotv force-pushed the feature/11029-v-model-migration branch from f0b453f to db22298 Compare August 6, 2024 15:13
@cnotv cnotv force-pushed the feature/11029-v-model-migration branch from db22298 to bc5fa2e Compare August 6, 2024 15:15
@cnotv cnotv marked this pull request as ready for review August 6, 2024 15:15
@cnotv cnotv force-pushed the feature/11029-v-model-migration branch from bc5fa2e to 0f99cc2 Compare August 7, 2024 09:43
@cnotv cnotv force-pushed the feature/11029-v-model-migration branch from 0f99cc2 to 4033494 Compare August 7, 2024 09:48
@cnotv
Copy link
Contributor Author

cnotv commented Aug 7, 2024

Closing in favor of a better approach in #11597

@cnotv cnotv closed this Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rak-phillip rak-phillip Awaiting requested review from rak-phillip

@codyrancher codyrancher Awaiting requested review from codyrancher

Assignees

@cnotv cnotv

Labels
None yet
Projects
None yet
Milestone
v2.10.0
Development

Successfully merging this pull request may close these issues.

Prevent errors in existing cases binding props with v-model
2 participants
@cnotv @nwmac