-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pagination changes given new vai cache backed steve api #11110
Merged
richard-cox
merged 83 commits into
rancher:master
from
richard-cox:pagination-with-vai-api
Jun 11, 2024
Merged
Pagination changes given new vai cache backed steve api #11110
richard-cox
merged 83 commits into
rancher:master
from
richard-cox:pagination-with-vai-api
Jun 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- New visuals - Pagination controls --> load more - finished testing of label select with pagination off # Conflicts: # shell/edit/provisioning.cattle.io.cluster/__tests__/Basics.tests.ts
- Setup pagination headers for the node type - Define a pattern for fetching custom list secondary resources - Major improvements to the way pagination settings are defined and created - Lots of docs improvements - Handle calling fetch again once fetch is in progress (nuxt caches running request) - Validate filter fields (not all are supported by the vai cache - General pagination fixes
- fix syntax - catch scenario where a pr has no fixed issue > There's duplication between files, see rancher#10534
…dall-secret-backup
- Everything is gated on `on-disk-steve-cache` feature flag - There's a backend in progress item to resolve a `revision` issue, until then disable watching a resource given it - Global Settings - Performance - Added new setting to enable server side pagination - this is incompatible with two other performance settings
… form Also - improved labeled select pagination - gate label select pagination functinality on steve cache being enabled
- project monitoring (and bug fixes)
- temp step until we get new overview
- only used in monitoring.coreos.com.alertmanagerconfig context
…electOrCreateAuthSecret
- Allow `None` option in Paginationed LabelSelect - Optionally classify pagination response
- update allowed fields given latest backend changes - enable on by default exact filter string matches (disable for lists
@codyrancher , @nwmac next PR ready to go. Smaller than the previous ones. One PR after this left, which is smaller again (and specifically to do with loading indicators) |
richard-cox
commented
Jun 11, 2024
richard-cox
commented
Jun 11, 2024
richard-cox
commented
Jun 11, 2024
- name was changed from on-disk-steve-cache to ui-sql-cache - fix timing issue - don't watch resources until we know the vai cache feature flag
richard-cox
commented
Jun 11, 2024
richard-cox
commented
Jun 11, 2024
nwmac
previously approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed with RC
- new exception in docs page - don't nav to page via button click and then goto same page
- force user to go to tab which is source of route guard issue - move setup stuff to a test for cypress to re-retry
nwmac
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on #10795Summary
Contributes to #9545 & #9964
Occurred changes and/or fixed issues
selector
s locally scales badly #10417Technical notes summary
count
is incorrect so ui will only show a single page of results and no page controlsAreas or cases that should be tested
This assumes UI pointing to an instance containing the new steve cache changes.
With both new steve cache feature flag and pagination performance setting enabled, and with both off
VALID_FIELDS
)Specifically with steve cache feature flag and pagination performance setting enabled
a
returns all rows with name containinga
, rather than just rows with a name ofa
)Specifically with steve cache feature flag and pagination performance setting disabled
Checklist