-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usages of findAll for types supported by server-side pagination #10795
Conversation
- New visuals - Pagination controls --> load more - finished testing of label select with pagination off # Conflicts: # shell/edit/provisioning.cattle.io.cluster/__tests__/Basics.tests.ts
- Setup pagination headers for the node type - Define a pattern for fetching custom list secondary resources - Major improvements to the way pagination settings are defined and created - Lots of docs improvements - Handle calling fetch again once fetch is in progress (nuxt caches running request) - Validate filter fields (not all are supported by the vai cache - General pagination fixes
- fix syntax - catch scenario where a pr has no fixed issue > There's duplication between files, see rancher#10534
…dall-secret-backup
- Everything is gated on `on-disk-steve-cache` feature flag - There's a backend in progress item to resolve a `revision` issue, until then disable watching a resource given it - Global Settings - Performance - Added new setting to enable server side pagination - this is incompatible with two other performance settings
… form Also - improved labeled select pagination - gate label select pagination functinality on steve cache being enabled
- project monitoring (and bug fixes)
- temp step until we get new overview
- only used in monitoring.coreos.com.alertmanagerconfig context
…electOrCreateAuthSecret
…most of the complexity
75ee276
to
42fbe1c
Compare
618ae07
to
8bf8b8b
Compare
@codyrancher @nwmac I'm having fun getting this one passed the gates (some might be geniune, but a lot of other prs are currently failing). The code should hopefully remain unchanged, would it be possible to review now to save time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't verify Harvester or S3 due to access.
From what I could verify it looks like we're still populating resources just fine.
Do you have a script or something for generating the resources in the future? It's fairly time consuming testing something like this.
@codyrancher Yeah there's a few requirements on certain types of secrets. I'm aiming to have some e2e tests where we can upload resources via YAML to populate pages. |
Blocked on #10786Summary
Contributes to #9964
Occurred changes and/or fixed issues
In Addition
WorkflowWorkloads list should not be navigatable. This will be replaced at some point with an overview pageRancher Backups
-->Backups
,Resource
-->Create
/edit page bottom bar (was not stuck to bottom)Technical notes summary
Feature Flag
Performance
settingAreas or cases that should be tested
Areas which could experience regressions
With both the performance pagination setting and feature flag off
Cluster Management
-->Cluster
list -->Create
-->RKE2
Harvester
-->User Data Template
andNetwork Data Template
contains correct config mapscontinues to work. Nav to
localcluster -->
Cluster Tools-->
Rancher Backup--> Next -->
Use an SE-compatible object store-->
Credential Secret should show valueslocal
cluster -->Apps
-->Repositories
-->Rancher
rowEdit Config
-->http(s) URL to an index generaed by Helm
-->Authentication
user can create either type and also select an existing oneCluster management
-->Cloud Credential
-->API Key
column should be populatedlocal
cluster -->Service Discovery
-->Ingresses
--> TheTarget
columns should contain /local
cluster -->Service Discovery
-->Ingress
--> click onrancher
-->Rules
tab --> confirmCertificate
column is populatedlocal
cluster -->Service Discovery
-->Ingresses
-->Create
-->Certificates
tab -->Certificate - Secret Name
contain at least one optionDefault Ingress Controller Certificate
and changing the namespace tokube-system
should then reveal another option (depends on kube flavour, on k3s its k2s-serving).local
cluster -->Cluster
-->Nodes
--> click on any node -->Pods
tab --> Confirm the pods list is populatedlocal
cluster --> (installRancher Backups
) -->Rancher Backups
-->Backups
-->Create
-->Encryption
--> SelectEncrypt backsps using...
--> Drop down below should be populated (conditions for secrets in tooltip must be met)local
cluster --> (installRancher Backups
) -->Rancher Backups
-->Restore
-->Create
--> SelectAn S3-compatible bject store
--> Drop down below should be populatedlocal
cluster --> (ensure a secret of typekubernetes.io/dockerconfigjson
has been created in a specific namespace) -->More Resources
-->ServiceAccounts
-->Create
--> select specific namespace -->Service Account
tab -->Pull Secrets
should contain secret. Changing the namespace should result in the correct secrets relative to that namespacelocal
cluster --> (Install monitoring and prometheus federator apps) -->Monitoring
-->Project Monitoring
--> can succesfully create and view oneThe above should be repeated with the performance pagination setting and feature flag on. In Addition
Checklist