Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update patch script to copy pkg annotations to uiplugin resource #11170

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

aalves08
Copy link
Member

@aalves08 aalves08 commented Jun 4, 2024

Summary

Fixes #11163

Occurred changes and/or fixed issues

  • update patch script to copy pkg annotations to uiplugin resource

Technical notes summary

Areas or cases that should be tested

  • create a new skeleton app: yarn create @rancher/app test-app
  • create a new pkg on app: yarn create @rancher/pkg test -t -w
  • copy the whole folder and it's subdirectories shell/scripts/extension to the root of the test-app
  • add an annotation to pkg test in rancher.annotations like:
"rancher": {
    "annotations": {
      "catalog.cattle.io/rancher-version": ">= v2.8.4",
      "jordon/did-this": "true"
    }
  },
  • run ./extension/publish -s test -b test -f and check the output on the charts folder

Areas which could experience regressions

Screenshot/Video

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@aalves08 aalves08 added this to the v2.9.0 milestone Jun 4, 2024
@aalves08 aalves08 self-assigned this Jun 4, 2024
@aalves08 aalves08 requested review from jordojordo and nwmac June 4, 2024 10:30
@aalves08 aalves08 requested a review from jordojordo June 4, 2024 14:27
@aalves08 aalves08 merged commit 289bef8 into rancher:master Jun 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve gating mechanism for extensions based on Extensions API version
3 participants