Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] - Adding Cluster Events table tests #11233

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

izaac
Copy link
Contributor

@izaac izaac commented Jun 13, 2024

Summary

Fixes rancher/qa-tasks#1384

Occurred changes and/or fixed issues

Updating the Cluster Dashboard events tests to include table headers validations. It currently does basic data validation.

Areas or cases that should be tested

Automation pipeline

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@izaac izaac added this to the v2.9.0 milestone Jun 13, 2024
@izaac izaac requested a review from yonasberhe23 June 13, 2024 17:30
@izaac izaac self-assigned this Jun 13, 2024
@izaac izaac force-pushed the cluster_events_table_tests branch 2 times, most recently from 4b0c006 to 6eff520 Compare June 13, 2024 17:58
@izaac izaac marked this pull request as draft June 13, 2024 18:53
@izaac izaac force-pushed the cluster_events_table_tests branch 5 times, most recently from 1c25316 to f0357a9 Compare June 14, 2024 18:33
@izaac izaac marked this pull request as ready for review June 14, 2024 18:34
@izaac izaac requested a review from yonasberhe23 June 14, 2024 18:35
Copy link
Contributor

@yonasberhe23 yonasberhe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment otherwise lgtm!

@izaac izaac force-pushed the cluster_events_table_tests branch from f0357a9 to dcb3aa5 Compare June 14, 2024 18:49
yonasberhe23
yonasberhe23 previously approved these changes Jun 14, 2024
@izaac izaac force-pushed the cluster_events_table_tests branch from 8d90a15 to 000ad0a Compare June 14, 2024 22:13
@yonasberhe23 yonasberhe23 self-requested a review June 14, 2024 23:35
@izaac izaac merged commit b53aaf6 into rancher:master Jun 14, 2024
26 checks passed
@izaac izaac deleted the cluster_events_table_tests branch June 14, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] VAI - Missing regression - Cluster Events
2 participants