Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vai pagination tests - cluster events #11234

Merged
merged 1 commit into from
Jun 14, 2024
Merged

vai pagination tests - cluster events #11234

merged 1 commit into from
Jun 14, 2024

Conversation

yonasberhe23
Copy link
Contributor

@yonasberhe23 yonasberhe23 commented Jun 13, 2024 •
edited
Loading

Summary

Fixes #rancher/qa-tasks#1380

Covers pagination functionality for cluster events list.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@yonasberhe23 yonasberhe23 added this to the v2.9.0 milestone Jun 13, 2024
@yonasberhe23 yonasberhe23 requested a review from izaac June 13, 2024 18:19
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_tests branch 3 times, most recently from 2b18f98 to b9f7a56 Compare June 13, 2024 19:49
@izaac izaac mentioned this pull request Jun 13, 2024
Merged
7 tasks
@yonasberhe23 yonasberhe23 force-pushed the vai_pagination_tests branch 4 times, most recently from 8b54bba to 2293734 Compare June 13, 2024 22:19
izaac
izaac reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@izaac izaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit about possibility to change the pag. buttons with test id locators. Looks good.

cypress/e2e/po/components/pagination.po.ts Show resolved Hide resolved
@izaac izaac mentioned this pull request Jun 14, 2024
Closed
@yonasberhe23 yonasberhe23 merged commit bf3dae1 into rancher:master Jun 14, 2024
26 checks passed
@yonasberhe23 yonasberhe23 deleted the vai_pagination_tests branch July 4, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izaac izaac izaac approved these changes

Assignees

@yonasberhe23 yonasberhe23

Labels
None yet
Projects
None yet
Milestone
v2.9.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yonasberhe23 @izaac