Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automation] - Use testid locators rather than positional on pagination #11248

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

izaac
Copy link
Contributor

@izaac izaac commented Jun 15, 2024

Summary

Fixes rancher/qa-tasks#1388

Positional locators aren't recommended and is a red flag on automation. Those shouldn't be used under any circumstance and is something commonly used as last resort.

Occurred changes and/or fixed issues

Added data-testid for pagination navigation buttons.

Areas or cases that should be tested

Automation is only affected and this isn't a functional change in the Vue code.

Test done: Cluster Pagination tests executed and passed.

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@izaac izaac added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jun 15, 2024
@izaac izaac added this to the v2.9.0 milestone Jun 15, 2024
@izaac izaac self-assigned this Jun 15, 2024
Copy link
Contributor

@yonasberhe23 yonasberhe23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yonasberhe23 yonasberhe23 merged commit a0d4e58 into rancher:master Jun 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI - Refactor the ui tables pagination locators
2 participants