Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE - allow user to edit master authorized network in provisioned clusters #11402

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #11391

Occurred changes and/or fixed issues

This PR updates the GKE networking component to allow editing the master authorized network cidr block keyvalue input. Per #11391, that keyvalue should be editable all the time but when a cluster is provisioned the master authorized checkbox should not be editable.

Areas or cases that should be tested

  1. Provision a GKE cluster - under the 'advanced' section in networking you should be able to enable master authorized networks and add some cidr blocks
  2. Once the cluster has finished provisioning, edit it and verify that you can update the list of cidr blocks

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@mantis-toboggan-md mantis-toboggan-md merged commit 1d5e5ea into rancher:master Jul 10, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2.9] GKE - Unable to add Master Authorized Network while Edit
2 participants