Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node pool name length validation and refactor to allow unit tests #11410

Merged

Conversation

mantis-toboggan-md
Copy link
Member

Summary

Fixes #11405 - see comments for expected behavior

Occurred changes and/or fixed issues

This PR updates the node pool name validator to check length as well as characters.

Areas or cases that should be tested

Open the AKS provisioning form and enter a pool name with >12 characters

  1. You should be prevented from saving
  2. There should be an error icon in the node pool name input
  3. If you add another pool and switch pool tabs, the inactive tab with validation error should have an error icon

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

@mantis-toboggan-md mantis-toboggan-md merged commit f8185c5 into rancher:master Jul 11, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while provisioning/updating a cluster is not printed on the edit form header
2 participants