AKS - fix tab component behavior when there are duplicate node pool names #11452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #11406
Occurred changes and/or fixed issues
This PR updates the AKS provisioning form to correct an issue with
Tab
props - duplicate pool names caused a problem due to tabs not having unique keys. This PR also adds validation for AKS pool name uniqueness.It's pretty easy to wind up with duplicate pool names here. In an effort to avoid adding QA burden to the fast-approaching 2.9.0 release I've filed a separate issue to improve node pool/group default naming more generally in a later release (#11451), as technically, that is not a release-blocker (the workaround is immediately obvious: manually re-name any duplicate pools you've inadvertently created).
Technical notes summary
To clarify the
Tab
props in play here: inCruAKS
Tab
components need akey
prop because they're part of av-for
loop...Tabs
within theTabbed
are also part of av-for
loop and thekey
used there is theTab
name
prop. ArguablyTabbed
should re-use thekey
prop when it is defined but it felt outside the scope of this issue to mess with such a widely used component.Areas or cases that should be tested
Checklist