Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Nodepool management misbehaves if initial nodepool is named 'pool1' #11406

Closed
valaparthvi opened this issue Jul 10, 2024 · 8 comments · Fixed by #11452
Closed

[AKS] Nodepool management misbehaves if initial nodepool is named 'pool1' #11406

valaparthvi opened this issue Jul 10, 2024 · 8 comments · Fixed by #11452
Assignees
Labels
kind/bug QA/manual-test Indicates issue requires manually testing status/release-blocker
Milestone

Comments

@valaparthvi
Copy link

valaparthvi commented Jul 10, 2024

Setup

  • Rancher version: v2.9-a9355940c0629ca419b7dd3e4098c4ea0e52c0c0-head
  • Rancher UI Extensions: master 46a44c1
  • Browser type & version:

Describe the bug

If the cluster initially has a single nodepool named 'pool1', subsequently adding/removing another nodepool becomes confusing.

To Reproduce

  1. Create an AKS cluster with only nodepool 'pool1'.
  2. Once the cluster has provisioned, try adding a new nodepool.

Result
Nodepool with name 'pool1' will be re-added. If you try removing the nodepool, all nodepools are removed.

Expected Result

It should not misbehave when trying to add a new nodepool
Screenshots

Screencast.from.07-10-2024.05.37.30.PM.webm

Also happens when renaming agentpool to pool1 during initial cluster creation.
Screencast from 07-10-2024 05:42:08 PM.webm

Additional context

Workaround:

  1. Add another nodepool, pool2 with system mode and update.
  2. Once the update is complete, edit the cluster to remove the nodepool 'pool1'.
  3. Once this update is complete, nodepool management seems to be back to working as expected again.
  4. When a new nodepool is added it will be called 'pool1', and the next one will be called 'pool3'.
@github-actions github-actions bot added the QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this label Jul 10, 2024
@valaparthvi valaparthvi self-assigned this Jul 11, 2024
@valaparthvi
Copy link
Author

@richard-cox @mantis-toboggan-md Can this get some love?

@mantis-toboggan-md mantis-toboggan-md added this to the v2.9.0 milestone Jul 16, 2024
@richard-cox richard-cox added QA/manual-test Indicates issue requires manually testing and removed QA/dev-automation Issues that engineers have written automation around so QA doesn't have look at this labels Jul 17, 2024
@valaparthvi
Copy link
Author

valaparthvi commented Jul 17, 2024

Tested on Rancher: v2.9-81337b95660cba868629d6fe769bd7e8242b5aee-head, Dashboard: master 3da1205.

It is only partially fixed.

I would not say it is blocking anymore, but the behavior can still be improvised.

Screencast.from.07-17-2024.06.05.04.PM.webm

@mantis-toboggan-md
Copy link
Member

I thought it could be better as well @valaparthvi but I didn't want to add too much to the 2.9.0 release at this stage so I filed an issue to improve node pool/group naming across the 3 hosted providers #11451

@izaac izaac self-assigned this Jul 17, 2024
@valaparthvi
Copy link
Author

@mantis-toboggan-md In that case, feel free to close this issue and track this in the one you filed.

@izaac
Copy link
Contributor

izaac commented Jul 17, 2024

Tech notes and test coverage details in PR. A manual QA validation will be executed before closing.

@valaparthvi
Copy link
Author

I am closing this issue in favor of tracking further enhancements in #11451.

@valaparthvi
Copy link
Author

Tech notes and test coverage details in PR. A manual QA validation will be executed before closing.

Manual QA validation is already done, see #11406 (comment).

@izaac
Copy link
Contributor

izaac commented Jul 18, 2024

I missed that comment. please do as needed thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug QA/manual-test Indicates issue requires manually testing status/release-blocker
Projects
None yet
4 participants