Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide Certificates table if vai is enabled #11528

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

richard-cox
Copy link
Member

Summary

Fixes #11524

Occurred changes and/or fixed issues

  • The Cluster Dashboard --> Certificates Tab --> Certificates list uses a filter that is not compatible with the Vai backed api
  • So hide the tab when vai is enabled

Technical notes summary

  • This is a 2.9 issue only, in 2.10 the table should be updated to handle the different way of filtering

Areas or cases that should be tested

As per issue

Checklist

  • The PR is linked to an issue and the linked issue has a Milestone, or no issue is needed
  • The PR has a Milestone
  • The PR template has been filled out
  • The PR has been self reviewed
  • The PR has a reviewer assigned
  • The PR has automated tests or clear instructions for manual tests and the linked issue has appropriate QA labels, or tests are not needed
  • The PR has reviewed with UX and tested in light and dark mode, or there are no UX changes

Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and all LGTM. With vai enabled, tab doesn't appear. Disabled vai and it appeared again.

The only comment is that if the milestone 2.9-next1 is correct, then I think the branch should be release/2.9 🤔

@richard-cox richard-cox changed the base branch from master to release-2.9 July 25, 2024 09:07
Copy link
Member

@aalves08 aalves08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- table uses a fitler which isn't compatible with new api so errors
@richard-cox richard-cox merged commit 1b1b20a into rancher:release-2.9 Aug 1, 2024
24 checks passed
@richard-cox richard-cox deleted the hide-certs-vai branch August 1, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants