-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support server-side pagination - alpha #9524
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9478
----------------
This is an alpha and not meant for production or review (see list of updates required)
----------------
Occurred changes and/or fixed issues
kubernetes.io/service-account-token
toSvc Acct Token
Ready
,Restarts
andIP
all come from schema --> metadata.fields[index] (attributes.columns[0].field: "$.metadata.fields[1])Updates post alpha
listGroupsWillOverride
. this isn't so neatwe re-fetch the list when we return to the page. this means the list is updated, but user has to wait for http request again. could leave as is, candidate for refresh buttonTODO: RC FIX
Updates that really should be in alpha
field
used to search instead of thevalue
Technical notes summary
General flow
Design / Patterns
are invalid. To get around this we define new headers which refer directly to properties on the raw resource. see pagination-table-headers
this means we avoid things like
name
&namespace
property helpers, searchFields that are functions to values, etcBackend / API Issues
differentcount
provided when adding/removingsort=-metadata.namespace
_type
field, yetsort=_type
does not work_type
field, yetfilter_type
does not workquestion.spec.containers
is an array of container objects. we'd like to sort/search using container.image.filter=spec.containers.image=alpine
as per docs. sorting doesn't make senseattributes.columns[3]
field
points to roughly the path in the pod object where the value is$.metadata.fields[3]"
.filter=metadata.fields.3=xyz
)sort: metadata.fields.3
)Areas or cases that should be tested