[v0.5] Fix agent not starting in fleet-system namespace #1322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the user wants to use fleet-system as the namespace to install the fleet-agent. If that is the case don't set the CattleNamespaceMigrated flag to false as it causes and endless loop of killing and starting the agent. Signed-off-by: raul <raul.cabello@suse.com>
thardeck
approved these changes
Feb 15, 2023
manno
changed the title
manno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the user wants to use
fleet-systemas the namespace to install thefleet-agent. We do that by checking if :In that case case don't set the
CattleNamespaceMigratedflag to false as it causes and endless loop of killing and starting the agent.I tested upgrade from rancher 2.5.15 to rancher 2.6.9 with this fix
backport to v0.5.0 from #1269