-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding capability for tolerations in the agent #703
Conversation
Update: Was able to test this and fix a few bugs. I would now consider this PR ready for review. Tests:
|
571a091
to
dc4dfa6
Compare
Overview of Changes:
|
dc4dfa6
to
5d3795a
Compare
Changing agent deployments to use tolerations defined on the fleet cluster, and changing the local cluster creation to use the tolerations from the controller deployment.
5d3795a
to
d0a4767
Compare
re:
I'm not sure if there might be use cases where a fleet-agent needs to have different tolerations than fleet? I'm not too concerned about this though. re:
This is where my primary concern is with the approach of this PR; I think that the specification of tolerations should happen in the downstream cluster, not the local cluster (where the fleet cluster object lives) since the current approach only works well if you are using Manager-Initiated registration (which is what Rancher uses). In Agent-Initiated registration, where the Cluster object is auto-created on seeing a ClusterRegistrationToken, there's undefined behavior since the Fleet Agent is deployed and managed via a Helm chart in the downstream cluster; in this case, these fields on the spec of the cluster in the management cluster would need to be effectively ignored right? |
Support for tolerations was added in PR #1154 |
Related to rancher/rancher#34159 . When the fleet controller is deployed, it deploys the fleet agent (both in the cluster which it is deployed in and in downstream clusters which use fleet). Currently, neither of these deployments allow specification of tolerations, making them difficult/impossible to use in a tainted cluster.
Goals of this PR: