Add support for Azure DevOps Webhook for gitRepos using SSH URL #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt regexp to match Azure DevOps git URLs although the URL returned from Azure is using HTTPS instead SSH, as configured in the GitRepo resource. Refers to SURE-7047, #2191
thehejik
approved these changes
Mar 7, 2024
There was a problem hiding this comment.
I successfully verified this PR on local rancher:2.8.3-rc2 by using my custom built gitjob image thehejik/gitjob:v0.9.3-azure. Fleet app version is fleet:103.1.1+up0.9.1-rc.5 and images are:
thehejik/gitjob:v0.9.3-azure
rancher/fleet:v0.9.1-rc.5
rancher/fleet-agent:v0.9.1-rc.5
I tested:
- Reproduced Azure SSH + Azure Webhook issue with original
rancher/gitjob:v0.9.3image - Azure SSH private repo + Azure Webhook and AUTH
- Azure HTTPS private repo + Azure Webhook and AUTH
- Azure HTTPS private repo + Azure Webhook and wrong AUTH - the gitjob wasn't triggered
- Github SSH private repo + Github Webhook and AUTH -
Failing in CI but worked on my env(original PR made from fork)
All went fine. Approving
manno
approved these changes
Mar 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt regexp to match Azure DevOps git URLs although the URL returned from Azure is using HTTPS instead SSH, as configured in the GitRepo resource.
Refers to SURE-7047
Refers to rancher/fleet#2191