Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for v0.8.3 #453

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Prepare for v0.8.3 #453

merged 4 commits into from
Mar 15, 2024

Conversation

thardeck
Copy link
Contributor

Refers to rancher/fleet#1998

@thardeck thardeck self-assigned this Mar 14, 2024
@thardeck thardeck requested a review from a team as a code owner March 14, 2024 15:29
@thardeck thardeck marked this pull request as draft March 14, 2024 15:44
@thardeck thardeck marked this pull request as ready for review March 14, 2024 15:53
thardeck and others added 4 commits March 15, 2024 06:50
Adapt regexp to match Azure DevOps git URLs although the URL returned from Azure
is using HTTPS instead SSH, as configured in the GitRepo resource.

Refers to SURE-7047, #2191
Copy link
Contributor

@weyfonk weyfonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks functionally equivalent to #446, hence LGTM
Would we need a docs update similar to this one?

@thardeck
Copy link
Contributor Author

Would we need a docs update similar to this one?
I think the feature was already back ported before, this was just a fix for it.

But if the documentation for 0.8 does not have webhook documentation yet, then we should add it I suppose.

@thardeck thardeck merged commit ede56c8 into release/fleet/v0.8 Mar 15, 2024
5 checks passed
@thardeck thardeck deleted the prepare_for_v0.8.3 branch March 15, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants