Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OEP: Allow user to specify anomalous keywords #1105

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AmartC
Copy link
Contributor

@AmartC AmartC commented Feb 21, 2023

No description provided.

@AmartC AmartC added the OEP Opni Enhancement Proposal label Mar 6, 2023
@sanjay920 sanjay920 added the aiops label Mar 6, 2023
@codyrancher
Copy link
Contributor

A couple notes to talk about

  1. The language "filter out" is being used in multiple places. Typically that means omit the matching items which I think is the opposite of the intent here.

  2. We already sort of do this in opensearch plugin. Are we wanting to remove that in favor of this?

  3. I wasn't a fan of doing this when we did it for the plugin. It's really odd to me for the user to tell us what's anomalous .

    1. The ML in theory should be doing this for the user.
    2. If the user is specifying it then it's not actually an anomaly. Instead, Ii's just keyword matching. Why are we conflating the two concepts?
  4. If we insist on doing this then I think I agree that this should be another page just to keep things simple.

  5. There was mention of workloads in here. Aren't we doing deployments instead?

@AmartC AmartC force-pushed the specify-anomalous-keywords branch from bdaa0b1 to 2c3c0e9 Compare March 9, 2023 21:48
@AmartC AmartC force-pushed the specify-anomalous-keywords branch from 9844526 to e6b50df Compare March 10, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aiops OEP Opni Enhancement Proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants