Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Switch from imported libcompose service commands to customized ones #1343

Merged
merged 1 commit into from
Oct 25, 2016

Conversation

joshwget
Copy link
Contributor

There are still some improvements that can be made, but this at least lays down a foundation and takes care of the following.

  • -d is now the default and --foreground must be used to log. --log might actually be better for this.
  • -f and -p are disabled.
  • At least one service must be specified for all service subcommands other than ps.

@ibuildthecloud
Copy link
Contributor

I think we still need further discussion on this. Like build?

@joshwget
Copy link
Contributor Author

We do, but I figured we could start here at least. I don't think there's really any story for build yet, so it should probably just be removed for now.

@ibuildthecloud
Copy link
Contributor

Definitely a good start. Would like to say LGTM but drone is having problems.

@ibuildthecloud
Copy link
Contributor

Merging with the caveat the more work needs to be done to cleanup ros service

@ibuildthecloud ibuildthecloud merged commit b8b4ddc into rancher:master Oct 25, 2016
@joshwget
Copy link
Contributor Author

#1287

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants