Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Azure public IPs #93

Merged
merged 2 commits into from
Jun 19, 2020
Merged

Use Azure public IPs #93

merged 2 commits into from
Jun 19, 2020

Conversation

nikkelma
Copy link
Contributor

Specify public and private IPs explicitly in all node registration commands.

Related issue:
#91

@nikkelma nikkelma requested a review from bashofmann June 18, 2020 17:21
bashofmann
bashofmann approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@bashofmann bashofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@nikkelma nikkelma merged commit a2afbcd into rancher:master Jun 19, 2020
@bashofmann bashofmann mentioned this pull request Jun 19, 2020
Closed
@nikkelma nikkelma deleted the azure-public-ips branch June 20, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashofmann bashofmann bashofmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikkelma @bashofmann