Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Custom global role creation #23453

Closed
rmweir opened this issue Oct 15, 2019 · 3 comments
Closed

[UI] Custom global role creation #23453

rmweir opened this issue Oct 15, 2019 · 3 comments
Assignees
Labels
Milestone

Comments

@rmweir
Copy link
Contributor

rmweir commented Oct 15, 2019

What kind of request is this (question/bug/enhancement/feature request):
enhancement

What:
UI for a admin to create custom global role and set it as default. Admin should be able to clone existing global role.

Backend Issue:
#16216

@rmweir rmweir changed the title [UI] [UI] Custom global role creation Oct 15, 2019
@rmweir rmweir added the team/ui label Oct 15, 2019
@rmweir rmweir added this to the v2.4 milestone Oct 15, 2019
@rmweir rmweir added the status/awaiting-backend Indicates a UI issue is waiting for a backend change to be merged before UI work can proceed label Oct 15, 2019
@tfiduccia
Copy link

UI - Will be same as it is for Cluster and Projects.

  1. Add button to top of Global role list that says "Add Global Role"
    image
  2. Click on button and there it should match Project & Cluster Add pages:
    image

@westlywright
Copy link
Contributor

westlywright commented Nov 19, 2019

Updates to the requirements for global roles:

  1. Locked is not a concept that exists on a global role so it will not be displayed in the UI.
  2. Inheritance isn't a concept that is applied to global roles as well so it is not displayed in the UI.

@jiaqiluo
Copy link
Member

jiaqiluo commented Dec 3, 2019

The feature is validated in master-head 5845c2d

  • Admin can add a custom global role
  • Admin can clone existing global roles

the global role page:
Screen Shot 2019-12-03 at 4 55 50 PM

adding/cloning a role:
Screen Shot 2019-12-03 at 4 52 25 PM

the role shows in the list:
Screen Shot 2019-12-03 at 4 52 35 PM

More tests will be done and bugs will be tracked by independent issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants