Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus-auth is using an old unmaintained version of Alpine Linux. #29290

Closed
rogersd opened this issue Sep 30, 2020 · 7 comments
Closed

prometheus-auth is using an old unmaintained version of Alpine Linux. #29290

rogersd opened this issue Sep 30, 2020 · 7 comments
Assignees
Labels
Milestone

Comments

@rogersd
Copy link

rogersd commented Sep 30, 2020

The Dockerfile for prometheus-auth specifies an old, unmaintained version of Alpine Linux (3.8).

This already contains multiple CVEs, such as:

CVE-2019-1551
CVE-2019-14697
CVE-2019-5482

It also specifies a two year old version of Go (1.11.1) that has multiple security fixes available: https://golang.org/doc/devel/release.html#go1.11

Please update this package and release a new version.

Thanks.

@aiyengar2
Copy link
Contributor

aiyengar2 commented Oct 13, 2020

Thanks for submitting this issue to us!

FYI I believe the Dockerfile.dapper linked in the original issue description is the one used by Dapper for our build scripts, so the Go version shouldn't make a difference, but I'll update that anyways.

However, it seems like the Dockerfile used for prometheus-auth is also still at alpine 3.8, so I'll update that to 3.12.

aiyengar2 pushed a commit to aiyengar2/prometheus-auth that referenced this issue Oct 13, 2020
aiyengar2 pushed a commit to aiyengar2/prometheus-auth that referenced this issue Oct 13, 2020
@rogersd
Copy link
Author

rogersd commented Oct 13, 2020

Thanks for submitting this issue to us!

FYI I believe the Dockerfile.dapper linked in the original issue description is the one used by Dapper for our build scripts, so the Go version shouldn't make a difference, but I'll update that anyways.

However, it seems like the Dockerfile used for prometheus-auth is also still at alpine 3.8, so I'll update that to 3.12.

Fantastic, thank you!

@aiyengar2
Copy link
Contributor

Note to QA

We initially had an issue in #29342 that tracked the 2.4 backport, but this issue is only ever being merged into 2.4 so I closed that ticket out in favor of this.

We should check in this ticket that the image is updated both in a 2.4 and 2.5 setup, but since the backend changes necessary are the same for both I'm leaving this as a single ticket to test both.

@jiaqiluo
Copy link
Member

jiaqiluo commented Oct 14, 2020

This bug fix is validated in rancher:v2.4-3950-head and rancher:v2.5-c32b5a14a8bc90a932c67735c3c42c44e48183e7-head single install, with the monitoring v1 0.1.4

Steps:

  • enable monitoring v1 0.1.4
  • set the branch of system-library to dev-v2.4
  • go the check the statefulSet prometheus-cluster-monitoring

Results:

  • the image rancher/prometheus-auth:v0.2.1 is used, and it uses alpine:3.12 and golang:1.15.2-alpine3.12 internally

Screen Shot 2020-10-14 at 2 57 01 PM

@rogersd
Copy link
Author

rogersd commented Oct 15, 2020

Thank you! I'll look forward to seeing this in the next release!

@deniseschannon
Copy link

@jiaqiluo Can you test this version for v2.4.9?

@jiaqiluo
Copy link
Member

jiaqiluo commented Oct 15, 2020

Close this issue since both v2.4-head and master-head were tested, and v2.4-head is for v2.4.9.
See my previous comment for details.
cc @deniseschannon

@zube zube bot removed the [zube]: Done label Jan 14, 2021
GGGitBoy pushed a commit to GGGitBoy/prometheus-auth that referenced this issue Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants