-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Monitoring v0.1.4 #357
Conversation
fa1b86a
to
456d431
Compare
@deniseschannon since v0.1.3 is already in Not sure if we need a new chart for this since
If we want to be safe, it should be easy to make the change though. |
Also, the changes to this chart will have no effect unless rancher/rancher#29478 is merged since any values supplied to |
@aiyengar2 Yes, it needs to be a new version, we are making changes to something that is already released. |
456d431
to
8e7d5c2
Compare
8e7d5c2
to
4e67b23
Compare
Updated! |
Since we're releasing a new version with this PR, I slightly modified the purpose of this PR to address both rancher/rancher#27253 and rancher/rancher#29290 since they are both minor changes. Merging this PR should be blocked based on resolving https://github.com/rancherlabs/eio/issues/280 and ensuring that the new prometheus-auth image exists on DockerHub. But no code changes will be introduced after that so this PR is still ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Related Issues: rancher/rancher#27253, rancher/rancher#29290