Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAML SLO support #45379

Commits on Aug 8, 2024

  1. extended auth provider types with flags for logout all support, i.e. …

    …supported, enabled, forced.
    
    added structures for logout request and response.
    regenerated code and yaml
    side work: documented nature of InitializeSamlServiceProvider
    global logout interceptor callback
    linked saml logout handler/backend with token manager frontend, via the interceptor callback
    added guards against UI misbehaviour
    register the new structures with the norman frame work to enable serialization to and from json
    added handling of SLO responses.
    inject slo support flag into the initial authconfigs
    fix: extended flow state storage with ability to set the cookie path.
    hardwired acs path is no good when redirecting to the slo endpoint.
    set proper cookie paths wherever we have state setup
    added request signing - applies only to logout requests
    (i.e. auth requests are not signed, as before)
    (because we apparently use the redirect binding despite the code saying POST)
    chore: log cleanup, removed some, made some official
    fix: comment typo in go.mod
    redirected crewjam/saml to our rancher/saml for decompression fix.
    fix: missing/different generated files
    fix KC logout issues with local crewjam patch.
    fix missing handling of detached signatures on responses
    import crewjam fix providing proper detached sig on logout requests.
    KC still ok.
    OKTA still fails, but different - issuer mismatch, not invalid sig
    address comment, drop todo note, crewjam/saml is forked, and fork used
    address comment - reduce saml logging
    
    Apply suggestions from code review
    Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
    
    address comments
    
    Apply suggestions from code review
    Co-authored-by: Paulo Gomes <paulo.gomes.uk@gmail.com>
    
    fixup of partial change for principled extension of redirect url with error information
    old code still needed for bad case (unparseable url)
    
    implemented todo: Assert "action == logout" && !sloForced, guard against UI misbehaviour.
    IOW, the UI will get an error now if it tries to perform a regular logout while the provider is configured for forced SLO, i.e. logout all as the only allowed method.
    andreas-kupries committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    682c689 View commit details
    Browse the repository at this point in the history
  2. fixup: CI error `pkg/auth/providers/saml/saml_provider.go:152:4: fmt.…

    …Sprintf does not support error-wrapping directive %w`
    andreas-kupries committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3f0c1b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2024

  1. Configuration menu
    Copy the full SHA
    3b5168e View commit details
    Browse the repository at this point in the history