Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use mktemp to save the cloud config #7

Merged
merged 1 commit into from
May 2, 2018
Merged

use mktemp to save the cloud config #7

merged 1 commit into from
May 2, 2018

Conversation

galal-hussein
Copy link
Contributor

@galal-hussein galal-hussein commented May 1, 2018 •
edited
Loading

moelsayed
moelsayed approved these changes May 2, 2018
View reviewed changes
Copy link
Contributor

@moelsayed moelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ibuildthecloud ibuildthecloud merged commit 4da551b into rancher:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moelsayed moelsayed moelsayed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@galal-hussein @moelsayed @ibuildthecloud