-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added canal's "IP autodetection methods " option in Canal chart #208
Conversation
See below for a detailed explanation of the options. https://projectcalico.docs.tigera.io/reference/node/configuration#ip-autodetection-methods
Could you rebase please? There is a conflicting file. Then I could review and merge :) |
packages/rke2-canal/package.yaml
Outdated
# This repository does not use releaseCandidateVersions, so you can leave this as 00. | ||
releaseCandidateVersion: 00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @manuelbuil
Thanks for the review.
It was included when I "forked" the file, so I left it in.
If it is not needed, we will delete it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK, this is not needed. However, in that same file, you should increase the packageVersion, otherwise CI will complain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your kindness.
I have deleted it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to increase the packageVersion
in packages/rke2-canal/package.yaml
. That's why CI is failing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for talomg up your time.
Updated 07 to 08.
Thanks for the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Delete unnecessary version information. Update packageVersion.
ece4bcb
to
9010108
Compare
Added canal's "IP autodetection methods " option in Canal chart
・Added canal's "IP autodetection methods " option
https://projectcalico.docs.tigera.io/reference/node/configuration#ip-autodetection-methods
・This will fix the following requirements
rancher/rke2#2324
・It has been tested in the following environments