Provide support for nodelocal DNSCache #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelbuil
force-pushed
the
coreDNS_nodeLocal
branch
from
cae8374
to
c96a7ca
Compare
brandond
approved these changes
Jul 27, 2021
manuelbuil
force-pushed
the
coreDNS_nodeLocal
branch
2 times, most recently
from
ccdb681
to
4501ed3
Compare
briandowns
approved these changes
Jul 27, 2021
brandond
requested changes
Jul 27, 2021
docs/networking.md
Outdated
| @@ -18,6 +18,12 @@ If you don't install CoreDNS, you will need to install a cluster DNS provider yo | |||
|
|
|||
| CoreDNS is deployed with the [autoscaler](https://github.com/kubernetes-incubator/cluster-proportional-autoscaler) by default. To disable it or change its config, use the [HelmChartConfig](https://docs.rke2.io/helm/#customizing-packaged-components-with-helmchartconfig) resource. | |||
|
|
|||
| ### NodeLocal DNSCache | |||
|
|
|||
| [NodeLocal DNSCache](https://kubernetes.io/docs/tasks/administer-cluster/nodelocaldns/) improves the performance by running a dns caching agent on each node. It is possible to activate this feature by using HelmChartConfig and updating the value `.Values.nodelocal.enabled` as can be seen in its [Chart](https://github.com/rancher/rke2-charts/blob/main/charts/rke2-coredns/rke2-coredns/1.16.201-build2021072302/values.yaml#L305-L311). The helm controller will redeploy coredns with the new config. Please be aware that nodelocal modifies the iptables of the node to intercept DNS traffic. Therefore, activating and then deactivating this feature without redeploying, will cause the DNS service to stop working. | |||
There was a problem hiding this comment.
Rather than linking to the values file, can you provide an example HelmChartConfig manifest to do this, similar to the one at https://github.com/rancher/rke2/blob/master/docs/helm.md#customizing-packaged-components-with-helmchartconfig
There was a problem hiding this comment.
Yes, makes more sense. They user will appreciate that more
manuelbuil
force-pushed
the
coreDNS_nodeLocal
branch
5 times, most recently
from
570a846
to
ce148e7
Compare
briandowns
approved these changes
Jul 29, 2021
brandond
approved these changes
Jul 29, 2021
manuelbuil
force-pushed
the
coreDNS_nodeLocal
branch
from
ce148e7
to
3f5d60e
Compare
Signed-off-by: Manuel Buil <mbuil@suse.com>
manuelbuil
force-pushed
the
coreDNS_nodeLocal
branch
from
3f5d60e
to
64966ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide support for nodelocal DNSCache
Linked issue: #1024
Signed-off-by: Manuel Buil mbuil@suse.com