Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to only using curl for windows scripts. #1571

Merged
merged 1 commit into from Aug 8, 2021
Merged

Switching to only using curl for windows scripts. #1571

merged 1 commit into from Aug 8, 2021

Conversation

phillipsj
Copy link
Contributor

@phillipsj phillipsj commented Aug 8, 2021

Signed-off-by: Jamie Phillips jamie.phillips@suse.com

Proposed Changes

PowerShell commandlets are notoriously slow to download files and make web requests. So switching to curl cuts installation time by 75%.

Types of Changes

New feature

Verification

Rancher and RKE2 installation scripts still function.

Linked Issues

Signed-off-by: Jamie Phillips <jamie.phillips@suse.com>
@phillipsj phillipsj requested a review from a team as a code owner August 8, 2021 02:22
@phillipsj phillipsj self-assigned this Aug 8, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1571 (a0e1077) into master (8d17937) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1571   +/-   ##
======================================
  Coverage    7.78%   7.78%           
======================================
  Files          21      21           
  Lines        1863    1863           
======================================
  Hits          145     145           
  Misses       1696    1696           
  Partials       22      22           
Flag Coverage Δ
unittests 7.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d17937...a0e1077. Read the comment docs.

@phillipsj phillipsj merged commit b25c1f4 into rancher:master Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants