New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.22 version bumps and use stable cni-plugins release #1838
Conversation
Reasoning:
|
Codecov Report
@@ Coverage Diff @@
## master #1838 +/- ##
======================================
Coverage 8.59% 8.59%
======================================
Files 21 21
Lines 1885 1885
======================================
Hits 162 162
Misses 1696 1696
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please hold off on merging this until #1827 lands; I'd prefer not to have Windows go to 1.22 before the rest of the project does.
@brandond is this is a technical limitation, supportability one, or other? Could this PR cause a breakage by being merged first? |
It just feels backwards; the servers should be upgraded before agents so it doesn't make sense to have the Windows agents on 1.22 while everything else is still on 1.21. I can merge that PR as it currently stands if that would help. At this point it's all just stuff in rke2-charts that needs to be fixed. |
@brandond that makes sense to me, I was just curious if there was a technical component I was missing here. Thanks for the explanation. |
06b2ca1
to
c9359aa
Compare
Proposed Changes
version bumps for the first rke2 release of 1.22
Calico to 3.20.1
Containerd to 1.5.7
cni-plugins to 1.0.1
no docs changed required
Types of Changes
version bumps only
Verification
dockerfile builds with new versions
Linked Issues
#1839
#1595
Further Comments