update multus chart to add optional dhcp daemonset #5146
Conversation
charts/chart_versions.yaml
Outdated
| @@ -20,7 +20,7 @@ charts: | |||
| - version: 2.11.100-build2023051511 | |||
| filename: /charts/rke2-metrics-server.yaml | |||
| bootstrap: false | |||
| - version: v4.0.2-build2023081103 | |||
| - version: v4.0.2-build2023081104 | |||
There was a problem hiding this comment.
Are there any new images that come with the changes to the chart, or does the DHCP daemonset use an existing image?
There was a problem hiding this comment.
no new images, it's using busybox
There was a problem hiding this comment.
I guess we should include busybox in the list of images for air-gap
There was a problem hiding this comment.
It looks like we for some reason specifically excluded the busybox image from the chart image validation scripts. If we're going to use busybox, we probably shouldn't exclude it from the list.
There was a problem hiding this comment.
I think I excluded busybox from the validation script because it's used in several charts but is never added in build-images so I assumed this was done on purpose.
Also several charts use the latest busybox instead of set version.
There was a problem hiding this comment.
busybox added to build-images
thomasferrandiz
force-pushed
the
multus-dhcp
branch
from
bfa159e
to
84a22f8
Compare
scripts/build-images
Outdated
| @@ -83,6 +83,7 @@ xargs -n1 -t docker image pull --quiet << EOF > build/images-multus.txt | |||
| ${REGISTRY}/rancher/hardened-sriov-network-resources-injector:v1.5-build20231009 | |||
| ${REGISTRY}/rancher/hardened-sriov-network-webhook:v1.2.0-build20230607 | |||
| ${REGISTRY}/rancher/hardened-whereabouts:v0.6.2-build20231009 | |||
| ${REGISTRY}/library/busybox:latest | |||
There was a problem hiding this comment.
We can't use the latest tag, there are different semantics for pulling when that is used, and it is not suitable for airgap use. We need to use a fixed tag. It sounds like this might require another change to the chart though?
Also, everything needs to come from ${REGISTRY}/rancher/, we can't consume things outside that project. I suggest you pick one of the mirrored busybox tags:
https://github.com/rancher/image-mirror/blob/master/images-list#L461
There was a problem hiding this comment.
I updated the chart to use the mirrored busybox from rancher
thomasferrandiz
force-pushed
the
multus-dhcp
branch
from
e022a10
to
91f176f
Compare
Linked issue: #3917