Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release 1.26] Add e2e test about dnscache #5228

Merged
merged 1 commit into from Jan 11, 2024

Conversation

manuelbuil
Copy link
Contributor

Backport: f860532
Issue: #5222

tests/e2e/dnscache/Vagrantfile Show resolved Hide resolved
tests/e2e/dnscache/dnscache_test.go Show resolved Hide resolved
@dereknola
Copy link
Contributor

Sorry @manuelbuil after discussion with Brad, I realized that I had it wrong on where we need to update the default branch, we update it in the CI infra, not in the tests themselves.

Copy link
Contributor

@dereknola dereknola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the changes based on my previous comments.

Signed-off-by: Manuel Buil <mbuil@suse.com>
@manuelbuil manuelbuil merged commit 6df5d2f into rancher:release-1.26 Jan 11, 2024
1 check passed
@manuelbuil manuelbuil deleted the dnstest126 branch January 11, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants