examples: add upgrade YAML for MicroOS #237
Conversation
|
This PR is ready for review |
Signed-off-by: Alberto Planas <aplanas@suse.com>
|
I tested this, and I found one issue with selinux (bsc#1210822) and k3s-selinux (bsc#1210824). Only the first one is important, but this plan has been tested and drive the installation until the end. |
|
cc @brandond |
| concurrency: 2 | ||
| nodeSelector: | ||
| matchExpressions: | ||
| - {key: node-role.kubernetes.io/worker, operator: In, values: ["true"]} |
There was a problem hiding this comment.
Are you sure about this? RKE2 and K3s do not use the 'worker' role so this will never match any nodes.
I know that the SLES example also has this, but I don't think it's correct there either.
There was a problem hiding this comment.
I label it as such, but I used the same that is in https://github.com/rancher/system-upgrade-controller/blob/master/examples/suse/sles.yaml#L26.
Can something like this be better? https://github.com/rancher/system-upgrade-controller/blob/master/examples/ubuntu/bionic.yaml#L31
There was a problem hiding this comment.
I don't know, none of these labels will exist by default - I guess the examples assume people understand that they need to label their nodes to match the LabelSelector in the plan? I don't mean to make you fix all of this; I approved so you can merge if you want .
There was a problem hiding this comment.
Excellent. I do not have rights to merge it. Can you do that?
Thanks!
….11.0 (#887) [](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rancher/system-upgrade-controller](https://togithub.com/rancher/system-upgrade-controller) | Kustomization | minor | `v0.10.0` -> `v0.11.0` | --- ### Release Notes <details> <summary>rancher/system-upgrade-controller</summary> ### [`v0.11.0`](https://togithub.com/rancher/system-upgrade-controller/releases/tag/v0.11.0) [Compare Source](https://togithub.com/rancher/system-upgrade-controller/compare/v0.10.0...v0.11.0) ##### What's Changed - Add support for PodSelector in DrainSpec by [@​brandond](https://togithub.com/brandond) in [rancher/system-upgrade-controller#231 - Set Kubernetes owner references on Job objects by [@​brandond](https://togithub.com/brandond) in [rancher/system-upgrade-controller#235 - examples: add upgrade YAML for MicroOS by [@​aplanas](https://togithub.com/aplanas) in [rancher/system-upgrade-controller#237 - Fix Spec.Drain.PodSelector by [@​brandond](https://togithub.com/brandond) in [rancher/system-upgrade-controller#239 - Bump github.com/rancher/wrangler from 0.8.11-0.20230207214913-209077f2d98f to 0.8.11 in /pkg/apis by [@​dependabot](https://togithub.com/dependabot) in [rancher/system-upgrade-controller#233 ##### New Contributors - [@​aplanas](https://togithub.com/aplanas) made their first contribution in [rancher/system-upgrade-controller#237 **Full Changelog**: rancher/system-upgrade-controller@v0.10.0...v0.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/RickCoxDev/home-cluster). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS43OS4xIiwidXBkYXRlZEluVmVyIjoiMzUuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
No description provided.