Merge pull request #1126 from mjura/eks-desired-size

Verify desired_size in EKSConfig NodeGroups
rancher · May 31, 2023 · 24a48c4 · 24a48c4
2 parents 0c6226a + 21788ec
commit 24a48c4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/rancher2/resource_rancher2_cluster.go b/rancher2/resource_rancher2_cluster.go
@@ -143,6 +143,9 @@ func resourceRancher2ClusterCreate(d *schema.ResourceData, meta interface{}) err
 	cluster.EnableClusterMonitoring = false
 	newCluster := &Cluster{}
 	if cluster.EKSConfig != nil && !cluster.EKSConfig.Imported {
+		if !checkClusterEKSConfigV2NodeGroupsDesiredSize(cluster) {
+			return fmt.Errorf("[ERROR] can't create %s EKS cluster with node group desired_size = 0", cluster.Name)
+		}
 		clusterStr, _ := interfaceToJSON(cluster)
 		clusterMap, _ := jsonToMapInterface(clusterStr)
 		clusterMap["eksConfig"] = fixClusterEKSConfigV2(d.Get("eks_config_v2").([]interface{}), structToMap(cluster.EKSConfig))

diff --git a/rancher2/structure_cluster_eks_config_v2.go b/rancher2/structure_cluster_eks_config_v2.go
@@ -398,3 +398,16 @@ func fixClusterEKSConfigV2NodeGroupsLaunchTemplate(p []interface{}) map[string]i
 
 	return obj
 }
+
+func checkClusterEKSConfigV2NodeGroupsDesiredSize(cluster *Cluster) bool {
+	if len(cluster.EKSConfig.NodeGroups) == 0 {
+		return false
+	}
+
+	for _, v := range cluster.EKSConfig.NodeGroups {
+		if *v.DesiredSize == 0 {
+			return false
+		}
+	}
+	return true
+}