Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify desired_size in EKSConfig NodeGroups #1126

Merged
merged 1 commit into from May 31, 2023
Merged

Verify desired_size in EKSConfig NodeGroups #1126

merged 1 commit into from May 31, 2023

Conversation

mjura
Copy link
Contributor

@mjura mjura commented May 19, 2023

Issue: #989

@mjura mjura changed the title Verify desired_size in EKSConfig NodeGroups [WIP] Verify desired_size in EKSConfig NodeGroups May 19, 2023
@mjura mjura mentioned this pull request May 19, 2023
Closed
@kkaempf kkaempf linked an issue May 23, 2023 that may be closed by this pull request
TF is unable to manage downstream EKS cluster resource w/ desired_size=0, max_size=1, min_size=0 #989
Closed
@mjura mjura changed the title [WIP] Verify desired_size in EKSConfig NodeGroups Verify desired_size in EKSConfig NodeGroups May 26, 2023
@mjura mjura requested a review from a team May 26, 2023 06:56
salasberryfin
salasberryfin approved these changes May 26, 2023
View reviewed changes
Copy link

@salasberryfin salasberryfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

furkatgofurov7
furkatgofurov7 reviewed May 26, 2023
View reviewed changes
Copy link
Contributor

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nitty:

rancher2/resource_rancher2_cluster.go Outdated Show resolved Hide resolved
@mjura mjura requested a review from furkatgofurov7 May 26, 2023 08:23
@mjura mjura merged commit 24a48c4 into rancher:master May 31, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salasberryfin salasberryfin salasberryfin approved these changes

@furkatgofurov7 furkatgofurov7 furkatgofurov7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TF is unable to manage downstream EKS cluster resource w/ desired_size=0, max_size=1, min_size=0
3 participants
@mjura @salasberryfin @furkatgofurov7