Implement Azure Tags Support #1012
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…azure machine config. add/update tests
HarrisonWAffel
force-pushed
the
azure-tags
branch
from
2eb41e9
to
9902ecd
Compare
|
Closed in favor of #1023 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#26955
This PR adds the
tagsfield to the node template, machine config, and cloud provider for Azure. This allows tags to be specified for particular VM instances using either the node template or machine config, as well as adding tags to supporting infrastructure via the tags field within the Azure cloud provider.Testing:
Manual testing is in progress, however I've added unit tests for the Azure node template and improved prior unit tests for the AmazonEC2 node template.
I'm raising this PR as a draft as the
tagsfield within the Azure Cloud Provider needs to be generated in rancher/rancher for this PR to work. Because of this dependency the build will fail