Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2.7.1] Add support for new azure features #1023

Conversation

HarrisonWAffel
Copy link
Contributor

@HarrisonWAffel HarrisonWAffel commented Nov 4, 2022

Issues: rancher/rancher#39458, rancher/rancher#26955, rancher/rancher#37847, rancher/rke#2611

Testing can be tracked in this ticket: #1071

This PR adds support for the following Azure features

  1. The Azure cloud provider now accepts tags. Expanders and flatteners now support that field
  2. The Azure machine config and node template now accept tags which are added to Azure VM Instances via rancher-machine. These tags
  3. The Azure machine config and node template now allow you to denote if you want to create a network interface utilizing Accelerated Networking.
  4. The Azure machine config and node template now allow you to denote if you want to create the Azure VM in a particular Availability Zone.
  5. The Azure machine config and node template now allow you to specify if you want to use the standard SKU for the public IP created for an Azure VM. This must be enabled for the creation of an Azure VM in a particular Availability Zone.

This PR also updates the version of rancher used as a dependency (and its indirect dependencies) to the latest commit of dev-v2.6, in order to pick up the new tags field in the Azure cloud provider.

Edit 1-06-2023:

I've resolved a build error that was blocking this PR. The drone runner was using go 1.17, however the most recent version of the Rancher dependency uses indirect dependencies which require at least 1.18 since they utilize generics. I've updated the drone runner to use go 1.19, as well as updated the version of docker being used to get around an alpine issue which was fixed in v3.14.

@HarrisonWAffel HarrisonWAffel requested a review from a team November 4, 2022 19:19
@HarrisonWAffel HarrisonWAffel marked this pull request as ready for review November 4, 2022 19:19
@a-blender a-blender changed the title [v2.7.1] Add support for new azure features [DNM v2.7.1] Add support for new azure features Nov 7, 2022
@a-blender
Copy link
Contributor

a-blender commented Nov 7, 2022

@HarrisonWAffel Generally we say [DNM v2.7.1] if a PR can only be merged pending a release branch existing ;) CI is also being flaky so I restarted it.

@HarrisonWAffel HarrisonWAffel changed the title [DNM v2.7.1] Add support for new azure features [v2.7.1] Add support for new azure features Nov 18, 2022
@HarrisonWAffel HarrisonWAffel force-pushed the azure-features-terraform-support branch from ef9f9de to 83ba0a1 Compare January 5, 2023 21:04
@HarrisonWAffel
Copy link
Contributor Author

HarrisonWAffel commented Jan 5, 2023

Now that the Azure features have been validated in the Rancher frontend and backend I've circled back on this PR for terraform support. I've run into similar issues as @annablender when bumping dependencies within go.mod, and found that some of the issues are caused when bringing in rancher 2.7. Bumping the rancher version to the latest commit of 2.6 resolves a majority of the issues regarding structured logging and other areas, but one is still present which is preventing this PR from proceeding.

I'm still looking into why this worked before the bump, and how to resolve the issue

edit:
It looks like some of the build steps for this PR are not using go 1.18, but new dependencies brought in by rancher require at least 1.18 as they contain generics.

@HarrisonWAffel HarrisonWAffel force-pushed the azure-features-terraform-support branch 4 times, most recently from 8777fb3 to d90e27c Compare January 5, 2023 22:54
.drone.yml Show resolved Hide resolved
Copy link
Contributor

@a-blender a-blender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

Copy link
Contributor

@jakefhyde jakefhyde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

rancher2/structure_node_template_azure_test.go Outdated Show resolved Hide resolved
rancher2/structure_node_template_azure_test.go Outdated Show resolved Hide resolved
… node template, and azure machine config. add/update tests, and update rancher dep
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants