New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2.7.1] Add support for new azure features #1023
[v2.7.1] Add support for new azure features #1023
Conversation
@HarrisonWAffel Generally we say [DNM v2.7.1] if a PR can only be merged pending a release branch existing ;) CI is also being flaky so I restarted it. |
ef9f9de
to
83ba0a1
Compare
Now that the Azure features have been validated in the Rancher frontend and backend I've circled back on this PR for terraform support. I've run into similar issues as @annablender when bumping dependencies within I'm still looking into why this worked before the bump, and how to resolve the issue edit: |
8777fb3
to
d90e27c
Compare
d90e27c
to
e169ed9
Compare
dfba204
to
912eaf6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
… node template, and azure machine config. add/update tests, and update rancher dep
912eaf6
to
d5466d4
Compare
Issues: rancher/rancher#39458, rancher/rancher#26955, rancher/rancher#37847, rancher/rke#2611
Testing can be tracked in this ticket: #1071
This PR adds support for the following Azure features
This PR also updates the version of rancher used as a dependency (and its indirect dependencies) to the latest commit of dev-v2.6, in order to pick up the new tags field in the Azure cloud provider.
Edit 1-06-2023:
I've resolved a build error that was blocking this PR. The drone runner was using go 1.17, however the most recent version of the Rancher dependency uses indirect dependencies which require at least 1.18 since they utilize generics. I've updated the drone runner to use go 1.19, as well as updated the version of docker being used to get around an alpine issue which was fixed in v3.14.