Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for server labels in hetzner_config #851

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Add support for server labels in hetzner_config #851

merged 4 commits into from
Jan 31, 2022

Conversation

stefandanaita
Copy link
Contributor

@stefandanaita stefandanaita commented Jan 21, 2022 •
edited by zube bot
Loading

This PR solves #657. The docker-machine-driver-hetzner latest tag makes the ServerLabels property public, so that should not be an issue anymore. 🤞🏻

@stefandanaita
Copy link
Contributor Author

@rawmind0 please have a look when you got some time 🙏🏻

rawmind0
rawmind0 suggested changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@rawmind0 rawmind0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefandanaita thanks for the PR.

Please take a look to changes requested

rancher2/schema_node_template_hetzner.go Outdated Show resolved Hide resolved
rancher2/schema_node_template_hetzner.go Outdated Show resolved Hide resolved
rancher2/structure_node_template_hetzner.go Show resolved Hide resolved
rancher2/structure_node_template_hetzner.go Show resolved Hide resolved
docs/resources/node_template.md Outdated Show resolved Hide resolved
@stefandanaita
Copy link
Contributor Author

Thank you @rawmind0! I'll make the requested changes and report back! 🙏🏻

@stefandanaita
Copy link
Contributor Author

Hi @rawmind0! I've addressed your comments, please have another look whenever you got some time!

rawmind0
rawmind0 suggested changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@rawmind0 rawmind0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @stefandanaita

Please, take a look to requested changes

rancher2/schema_node_template_hetzner.go Outdated Show resolved Hide resolved
docs/resources/node_template.md Outdated Show resolved Hide resolved
@stefandanaita
Copy link
Contributor Author

stefandanaita commented Jan 26, 2022 •
edited
Loading

Done @rawmind0, thank you for the comments and apologies for the headache! 🙏🏻

rawmind0
rawmind0 approved these changes Jan 31, 2022
View reviewed changes
Copy link
Contributor

@rawmind0 rawmind0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rawmind0 rawmind0 merged commit b5b1f4c into rancher:master Jan 31, 2022
@rawmind0 rawmind0 mentioned this pull request Jan 31, 2022
Closed
@stefandanaita
Copy link
Contributor Author

Thank you @rawmind0! Any chance you're going to do a new release soon so we can use the new provider version? 🙏🏻

@stefandanaita
Copy link
Contributor Author

Bump @rawmind0 🙏🏻

@denismatiu
Copy link

up ^🙏🏻

@stefandanaita
Copy link
Contributor Author

Up again @rawmind0 🙏🏻 😢

@rawmind0
Copy link
Contributor

Sorry @stefandanaita , but i'm not an org member anymore

@stefandanaita
Copy link
Contributor Author

Oh no! Do you know who's going to be the main maintainer going forward? 👀

@process0 process0 mentioned this pull request May 21, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawmind0 rawmind0 rawmind0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefandanaita @denismatiu @rawmind0