test: avoid leaking sensitive information in e2e logs #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
added
the
kind/enhancement
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
hide-sensitive-information-e2e-tests
branch
from
a5e5c78
to
943c36e
Compare
salasberryfin
changed the title
alexander-demicev
approved these changes
Nov 28, 2023
richardcase
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
While looking for an alternative solution to fix the E2E tests failing in GitHub Actions, we identified that sensitive data used for environment configuration is shown in the logs if we move to Prow. To obfuscate this information, we can populate a values file (which only exists in the container that runs the E2E, which can be considered secure).
Which issue(s) this PR fixes:
Fixes #265
Special notes for your reviewer:
Checklist: