feat: helm chart supports digest and tag for container image #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
force-pushed
the
chart-support-digest-and-tag-for-image
branch
12 times, most recently
from
6351c55
to
18b9087
Compare
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
salasberryfin
force-pushed
the
chart-support-digest-and-tag-for-image
branch
from
18b9087
to
bf19349
Compare
salasberryfin
changed the title
alexander-demicev
approved these changes
Nov 28, 2023
richardcase
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change adapts chart templates and chart creation to support both digests and tags for controller image version.
A new variable
CONTROLLER_IMAGE_VERSIONis added to keep track of the image version andRELEASE_TAGwill now only be used for chart versioning.CONTROLLER_IMAGE_VERSIONwill default to latest tag if not explicitly specified when creating a new chart release. Since digests and tags use different separators (@vs:) between image and version, templatedeployment.yamlimplements a condition to use the correct image based on the format of the version.In addition, it modifies the release GitHub Action to create the Helm chart using the digest for the multiarch image (only for prod).
Which issue(s) this PR fixes:
Fixes #215
Special notes for your reviewer:
Pending reviewing release workflow.Checklist: