🌱 chore: cover uninstall in e2e tests #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salasberryfin
changed the title
alexander-demicev
previously approved these changes
Apr 18, 2024
There was a problem hiding this comment.
PR looks good but I have same concerns as @salasberryfin about merging it before solving uninstall issue upstream in CAPI Operator.
+1 |
|
Thanks for the reviews. Since we agree on waiting for the issue to be solved before merging this, I moved the original ticket to blocked. |
Danil-Grigorev
previously approved these changes
Apr 30, 2024
richardcase
previously approved these changes
May 1, 2024
|
I’ll take care of rebase as Carlos is on PTO. |
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Danil-Grigorev
dismissed stale reviews from richardcase, alexander-demicev, and themself
via
0387e89
Danil-Grigorev
force-pushed
the
e2e-cover-uninstall
branch
from
72a684d
to
0387e89
Compare
furkatgofurov7
approved these changes
May 2, 2024
alexander-demicev
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After running the
import-gitopstest suite, we verify thathelm uninstallworks on Turtles. This also upgrades Helm tov3.14.0, asv3.8.1was failing to detect the--cascadeflag.Which issue(s) this PR fixes:
Fixes #410
Special notes for your reviewer:
The uninstall of Turtles may fail unexpectedly due to a problem with the CAPI Operator Helm chart and CRDs being deleted in such a way that doesn't guarantee the order and may end up in a deadlock caused by a finalizer that is never removed.
Note: perhaps we should wait to have this sorted out before merging this change and having the uninstall step as part of the E2E tests.
Checklist: