🐛 B64 encode gcp credentials for credentials sync #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
|
Closing as upon testing in #510 (comment) this is not needed (not an issue). |
Danil-Grigorev
changed the title
|
Apparently I was verifying issue with the built image included, even after double checking and rebuilding from main… At least the issue fix was tested locally. |
furkatgofurov7
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Rancher credentials for GCP are not encoded in b64 on retrieval from secret. We need to encode this once in the credentials syncing and second time by specifying the data in the
stringDatafield.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #510
Special notes for your reviewer:
Checklist: