-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: restructure e2e v1v3 suites #594
test: restructure e2e v1v3 suites #594
Conversation
7626b45
to
5a7ff7b
Compare
5a7ff7b
to
53a2f9c
Compare
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
53a2f9c
to
7743511
Compare
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
72d6847
After some investigation, we found the CAPD is not the source of the error but it still makes sense to keep it with the same CAPI version, maybe we can also include the CAPD version downgrade in this PR. |
Signed-off-by: Carlos Salas <carlos.salas@suse.com>
Thanks @alexander-demicev @Danil-Grigorev, I included the downgrade in the pr. |
Is this really necessary to do? I had an impression we will go down that path if the problem was with CAPD, but might be misunderstood . |
@furkatgofurov7 It's probably not mandatory but we can potentially avoid any issues related to version differences. We will bump CAPI to the latest soon and bring back these tests. We would also need to do some other CAPRKE2 tests that use providers like AWS to test something real that users might deploy. |
What this PR does / why we need it:
Structure E2E in differentiated suites for v3 checks, including adding validations for
embedded-capi-disabled
which so far only has v1 test coverage.Additionally, this disables tests involving CAPRKE2 + CAPD until we bump CAPI version.
Which issue(s) this PR fixes:
Fixes #477
Special notes for your reviewer:
Checklist: