Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin CAAPF version to v0.3.0 #614

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Jul 24, 2024

What this PR does / why we need it:
Pinned CAAPF to version 0.3.0 and marked it as non-experimental.

Since fleet released v0.10.1-rc.1, but it is not a part of rancher/charts yet, this PR can’t add full e2e suite, which will convert CNI installation to the cluster using fleet and enable hostNetwork: true setting.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #615

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner July 24, 2024 13:58
Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
Copy link
Member

@alexander-demicev alexander-demicev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) July 24, 2024 16:02
Copy link

@mjura mjura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only small comment but in overall lgtm

@Danil-Grigorev Danil-Grigorev merged commit f4a20bb into rancher:main Jul 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fleet addon to the turtles E2E suite
4 participants