Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use k8s 1.30.3 #668

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

Danil-Grigorev
Copy link
Contributor

@Danil-Grigorev Danil-Grigorev commented Aug 16, 2024

What this PR does / why we need it:

Version 1.30.0 had issues collecting resources using crust-gather, due to kubernetes/kubernetes#126739. 1.30.3+ no longer have this problem.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@Danil-Grigorev Danil-Grigorev requested a review from a team as a code owner August 16, 2024 14:23
@Danil-Grigorev Danil-Grigorev force-pushed the bump-k8s-1.30.4 branch 2 times, most recently from 28f38cb to 355e76b Compare August 16, 2024 14:40
test/e2e/config/operator.yaml Outdated Show resolved Hide resolved
test/e2e/config/operator.yaml Outdated Show resolved Hide resolved
hack/ensure-kubectl.sh Show resolved Hide resolved
@furkatgofurov7
Copy link
Contributor

furkatgofurov7 commented Aug 16, 2024

I think this PR might supersede #667 to fix e2e nightly tests, but let's wait for short e2e tests to pass also.

- Use RKE2_VERSION where possible
- Rename vsphere CPI_IMAGE_VERSION

Signed-off-by: Danil-Grigorev <danil.grigorev@suse.com>
@Danil-Grigorev Danil-Grigorev changed the title 🌱 Use k8s 1.30.4 🌱 Use k8s 1.30.3 Aug 16, 2024
@Danil-Grigorev Danil-Grigorev enabled auto-merge (squash) August 16, 2024 16:37
@Danil-Grigorev Danil-Grigorev merged commit 2276e2e into rancher:main Aug 16, 2024
23 checks passed
@xyz-li
Copy link

xyz-li commented Aug 17, 2024

kubernetes/kubernetes#126739 has been fixed in v1.30.4, not v1.30.3.

@Danil-Grigorev
Copy link
Contributor Author

I actually checked 1.30.4 as well and saw it working 😄 It is not a blocker, just an inconvenience, as it makes logs collection to timeout when it performs full resource discovery. Ended up with 1.30.3 by mistake

Thanks for confirmation and for the fix 🙂 @xyz-li

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants