Migrate release-2.0-untagged to gha #453
Conversation
.github/workflows/ci.yaml
Outdated
| - amd64 | ||
| - arm64 | ||
| runs-on: org-${{ github.repository_owner_id }}-${{ matrix.arch }}-k8s | ||
| container: registry.suse.com/bci/golang:1.22 |
There was a problem hiding this comment.
Shouldn't the go version in CI match the go version used by this branch? It seems like we have GHA using 1.22 while the base version should be 1.20 according to go.mod in this branch: https://github.com/rancher/wrangler/blob/release-2.0-untagged/go.mod
There was a problem hiding this comment.
Bumped the go version to 1.22 instead -- just because a branch is based on an older version doesn't mean it has to use an older version of go.
There was a problem hiding this comment.
For wrangler & lasso we try to keep the same Go version that's being used by the k8s library to not add more constraints for users of those libraries. k8s 1.27 requires a minimum version of Go 1.20 so we would keep it as is and instead change the container to use golang 1.20.
There was a problem hiding this comment.
OK, I pulled this branch back to golang 1.20
And also uses SHAs to specify github action versions.
Related to: #45226 - for branch
release-2.0-untagged