fix: add aws_s3_bucket_ownership_controls resource for statestore module so ACL can be created. #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt behavior before 2023.04 of AWS S3.
This was referenced Apr 24, 2023
|
Any review resource I can get on this? Internally at our org we have accommodated the change into our fork but keep this PR on pending will affect other folks in the community who are relying on this module, I'm afraid. Thanks! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out AWS has changed their default ACL behavior of S3 buckets since 2023/04: https://aws.amazon.com/blogs/aws/heads-up-amazon-s3-security-changes-are-coming-in-april-of-2023/
This PR adds
aws_s3_bucket_ownership_controlstostatestoremodule to mimic the default behavior before 2023.04 of AWS S3.