Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove error message on MS Excel 2010 #263

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

rds13
Copy link

@rds13 rds13 commented Nov 9, 2013

Excel says the file is corrupted if the XML contains empty xml nodes.
Those modifications try to no emit xml nodes if they are empty.

@jurriaan
Copy link
Collaborator

jurriaan commented Jan 3, 2014

I think this is good to merge if it's compliant with the specs.. But I'm not sure..

@trusche
Copy link

trusche commented Jan 16, 2014

I can confirm that this gets rid of the error messages in Excel. Would be great if this could be merged!

@randym
Copy link
Owner

randym commented Feb 26, 2014

@trusche have you confirmed this against the actual ECMA specs?

@trusche
Copy link

trusche commented Mar 2, 2014

@randym No I have not, sorry - I just needed a quick fix. If this isn't spec conform, ignore my comment please.

@jurriaan
Copy link
Collaborator

jurriaan commented Mar 3, 2014

I don't think this is always true for empty elements. When using text runs, Excel itself emits empty elements for the markup.
Are you sure these changes are all needed?
And is it possible to merge/squash your commits?

@spkprav
Copy link

spkprav commented Sep 19, 2017

@rds13 Hi, I see this is very old, but the issue with line chart still exists, any idea how to solve that?
I tried using this code, but still getting issues at MS Excel 2013, bar chart works fine though.
Any help will be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants