updates #488
updates #488
Conversation
| str << "/>" | ||
| end | ||
| str << '</dataFields>' | ||
| end | ||
| # custom style | ||
| if style_info.present? |
There was a problem hiding this comment.
Hash#present? is not defined when running the tests.
ActiveSupport is not available as a depdendency.
|
thanks for pointing out the issue, it's fixed now |
| '<pivotField axis="axisRow" compact="0" outline="0" subtotalTop="0" showAll="0" includeNewItemsInFilter="1" defaultSubtotal="0">' + '</pivotField>' | ||
| else | ||
| '<pivotField axis="axisRow" compact="0" outline="0" subtotalTop="0" showAll="0" includeNewItemsInFilter="1">' + '<items count="1"><item t="default"/></items>' + '</pivotField>' | ||
| end |
There was a problem hiding this comment.
Style detail: Never use unless with an else. https://github.com/bbatsov/ruby-style-guide#no-else-with-unless
There was a problem hiding this comment.
Sorry I'm used to Java which doesnt deal with unless
There was a problem hiding this comment.
I will update based on ruby style guide
|
Perhaps you can improve the title of this PR, to make it work in a CHANGELOG document, if it ever gets that far? |
| elsif columns.include? cell_ref | ||
| '<pivotField axis="axisCol" compact="0" outline="0" subtotalTop="0" showAll="0" includeNewItemsInFilter="1">' + '<items count="1"><item t="default"/></items>' + '</pivotField>' | ||
| elsif pages.include? cell_ref | ||
| '<pivotField axis="axisCol" compact="0" outline="0" subtotalTop="0" showAll="0" includeNewItemsInFilter="1">' + '<items count="1"><item t="default"/></items>' + '</pivotField>' | ||
| '<pivotField axis="axisPage" compact="0" outline="0" subtotalTop="0" showAll="0" includeNewItemsInFilter="1">' + '<items count="1"><item t="default"/></items>' + '</pivotField>' |
There was a problem hiding this comment.
This is a bug-fix, right?
There was a problem hiding this comment.
Correct... will work on CHANGELOG
|
@ehallmark as you make the changes requested by @olleolleolle please be sure to rebase and add specs covering you changes. |
First, we override stylesheet/num_fmt.rb in order to prevent the removal of underscores in number foramatting. (This solution was provided in a previous issue)
Second, we add attributes in the pivot_table class to handle pivotStyleInfo and whether row attributes ought to include the subtotal in the pivot table.