Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivot table bugs #499

Merged
merged 4 commits into from Nov 15, 2016
Merged

Pivot table bugs #499

merged 4 commits into from Nov 15, 2016

Conversation

ehallmark
Copy link
Contributor

@ehallmark ehallmark commented Nov 7, 2016

Fixes issues in the pivot table class and one tiny fix to number formats to avoid removing underscores

@ehallmark ehallmark mentioned this pull request Nov 7, 2016
@randym
Copy link
Owner

randym commented Nov 15, 2016

Thanks ehallmark - Eventually we are going to have to build out the Pivot Table objects instead of conditionally generating large blocks of xml strings. For now, at least this sorts out some of the issues people are having with the naive original implementation.

@randym randym merged commit b0d74cf into randym:master Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants