Skip to content
This repository has been archived by the owner on May 25, 2021. It is now read-only.

Settings menu doesn't close when the user clicks outside of it. #436

Closed
vanessayuenn opened this issue Jun 16, 2016 · 3 comments
Closed

Settings menu doesn't close when the user clicks outside of it. #436

vanessayuenn opened this issue Jun 16, 2016 · 3 comments
Assignees
@ericjim
Labels
bug

Comments

@vanessayuenn
Copy link
Contributor

vanessayuenn commented Jun 16, 2016 •
edited
Loading

image

TODO: write more details here
@sumitarora sumitarora added the bug label Jun 17, 2016
@sumitarora sumitarora self-assigned this Jun 17, 2016
@sumitarora sumitarora mentioned this issue Jun 17, 2016
Merged
@clbond
Copy link
Contributor

clbond commented Jun 17, 2016

This is not fixed, reopening

@clbond clbond reopened this Jun 17, 2016
@ericjim
Copy link
Contributor

ericjim commented Jun 29, 2016

I'll look into it.

@ericjim ericjim assigned ericjim and unassigned sumitarora Jun 29, 2016
@ericjim ericjim mentioned this issue Jul 5, 2016
Merged
@ericjim
Copy link
Contributor

ericjim commented Jul 7, 2016

#477 only address this issue partially. There are two edge cases that need to be addressed:

  • Clicking on the augury-header does not hide the menu when the menu is revealed.
  • Clicking on the scroll bars does not hide the menu when the menu is revealed.

andrewlo pushed a commit that referenced this issue Aug 8, 2016
fixes #436 - Close theme menu when clicking outside of it.
d22a1ae
@xorgy xorgy changed the title settings menu should close when click outside of it Settings menu doesn't close when the user clicks outside of it. Sep 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ericjim ericjim

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@sumitarora @ericjim @andrewlo @clbond @vanessayuenn